Laravel 13 support - #39
Open
MitchBred wants to merge 45 commits into
Open
Conversation
Bumps [overtrue/phplint](https://github.com/overtrue/phplint) from 9.1 to 9.2. - [Release notes](https://github.com/overtrue/phplint/releases) - [Changelog](https://github.com/overtrue/phplint/blob/main/CHANGELOG.md) - [Commits](overtrue/phplint@9.1...9.2) --- updated-dependencies: - dependency-name: overtrue/phplint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rue/phplint-9.2 Bump overtrue/phplint from 9.1 to 9.2
Bumps [overtrue/phplint](https://github.com/overtrue/phplint) from 9.2 to 9.3. - [Release notes](https://github.com/overtrue/phplint/releases) - [Changelog](https://github.com/overtrue/phplint/blob/main/CHANGELOG.md) - [Commits](overtrue/phplint@9.2...9.3) --- updated-dependencies: - dependency-name: overtrue/phplint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
update to php 8.2 (laravel 11)
…rue/phplint-9.3 Bump overtrue/phplint from 9.2 to 9.3
dep: update
Bumps [brick/math](https://github.com/brick/math) from 0.11.0 to 0.12.1. - [Release notes](https://github.com/brick/math/releases) - [Changelog](https://github.com/brick/math/blob/master/CHANGELOG.md) - [Commits](brick/math@0.11.0...0.12.1) --- updated-dependencies: - dependency-name: brick/math dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [overtrue/phplint](https://github.com/overtrue/phplint) from 9.3 to 9.4. - [Release notes](https://github.com/overtrue/phplint/releases) - [Changelog](https://github.com/overtrue/phplint/blob/main/CHANGELOG.md) - [Commits](overtrue/phplint@9.3...9.4) --- updated-dependencies: - dependency-name: overtrue/phplint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rue/phplint-9.4 Bump overtrue/phplint from 9.3 to 9.4
…0.12.1 Bump brick/math from 0.11.0 to 0.12.1
Bumps [nikic/php-parser](https://github.com/nikic/PHP-Parser) from 5.1.0 to 5.3.1. - [Release notes](https://github.com/nikic/PHP-Parser/releases) - [Changelog](https://github.com/nikic/PHP-Parser/blob/master/CHANGELOG.md) - [Commits](nikic/PHP-Parser@v5.1.0...v5.3.1) --- updated-dependencies: - dependency-name: nikic/php-parser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [overtrue/phplint](https://github.com/overtrue/phplint) from 9.4 to 9.5. - [Release notes](https://github.com/overtrue/phplint/releases) - [Changelog](https://github.com/overtrue/phplint/blob/main/CHANGELOG.md) - [Commits](overtrue/phplint@9.4...9.5) --- updated-dependencies: - dependency-name: overtrue/phplint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rue/phplint-9.5 Bump overtrue/phplint from 9.4 to 9.5
…arser-5.3.1 Bump nikic/php-parser from 5.1.0 to 5.3.1
Bumps [voku/portable-ascii](https://github.com/voku/portable-ascii) from 2.0.1 to 2.0.3. - [Changelog](https://github.com/voku/portable-ascii/blob/master/CHANGELOG.md) - [Commits](voku/portable-ascii@2.0.1...2.0.3) --- updated-dependencies: - dependency-name: voku/portable-ascii dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [nikic/php-parser](https://github.com/nikic/PHP-Parser) from 5.3.1 to 5.4.0. - [Release notes](https://github.com/nikic/PHP-Parser/releases) - [Changelog](https://github.com/nikic/PHP-Parser/blob/master/CHANGELOG.md) - [Commits](nikic/PHP-Parser@v5.3.1...v5.4.0) --- updated-dependencies: - dependency-name: nikic/php-parser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…arser-5.4.0 Bump nikic/php-parser from 5.3.1 to 5.4.0
…le-ascii-2.0.3 Bump voku/portable-ascii from 2.0.1 to 2.0.3
- Updated Entrust class with role and permission checks - Added route filtering methods for roles and permissions - Added unit tests for EntrustUser functionality - Added tests for role and permission checks - Added tests for attaching and detaching roles - Added tests for ability method with various return types - Mocked necessary dependencies and configurations
- Updated nesbot/carbon to version ^3.8.4 - Updated nunomaduro/termwind to version ^2.0
- Updated brick/math to version ^0.12 - Updated hamcrest/hamcrest-php to version ^2.0.1
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [overtrue/phplint](https://github.com/overtrue/phplint) from 9.5 to 9.8. - [Release notes](https://github.com/overtrue/phplint/releases) - [Changelog](https://github.com/overtrue/phplint/blob/main/CHANGELOG.md) - [Commits](overtrue/phplint@9.5...9.8) --- updated-dependencies: - dependency-name: overtrue/phplint dependency-version: '9.8' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 6. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v6) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
brick/math komt nergens in src/ voor. De regel is een overblijfsel van het platslaan van de dependency-tree naar composer.json, net als psr/cache, voku/portable-ascii en de symfony/polyfill-* regels. De pin blokkeert wel Laravel 13: die vraagt brick/math ^0.14.2 of nieuwer, dus een project dat entrust gebruikt loopt vast op mitchbred/entrust 2.5.8 requires brick/math ^0.12 -> found brick/math[0.12.0, ..., 0.12.3] but it conflicts with your root composer.json require Zonder deze regel resolvet laravel/framework v13.24.0 schoon. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix: verwijder brick/math uit require
…ns/cache-6 Bump actions/cache from 4 to 6
…ns/checkout-7 Bump actions/checkout from 4 to 7
…ns/dependency-review-action-5 Bump actions/dependency-review-action from 4 to 5
…rue/phplint-9.8 Bump overtrue/phplint from 9.5 to 9.8
Het weghalen van de brick/math pin maakte entrust installeerbaar naast Laravel 13, maar niemand kon zien of het er ook op werkte. Deze commit regelt dat. CI verifieerde niets. De workflow triggerde op master terwijl de default branch main heet, en de teststap stond uitgecommentarieerd. Wat er draaide was composer validate plus een install. Nu draait hij op main, met een matrix over Laravel 12 en 13, en roept hij het test-script aan dat er nog niet was. minimum-stability stond op dev met prefer-stable false. Daardoor resolveerde alles naar dev-branches: illuminate/support 13.x-dev, phpunit 12.5.x-dev en mockery 2.0.x-dev. Die laatste alleen al gaf 44 deprecations. Nu stable met prefer-stable true, en mockery ^1.6 en rector ^2.0 in plaats van versies die geen stable release hebben. De require-lijst was een platgeslagen dependency-tree van 47 pakketten waarvan er 39 transitief zijn. Dat is waar de brick/math pin vandaan kwam, en zonder opschonen komt de volgende blocker er bij Laravel 14 gewoon weer in. Teruggebracht tot de acht illuminate-pakketten die de source echt aanraakt: cache voor TaggableStore, console voor Command, contracts voor Auth\Guard, database voor Model, Migration, Blueprint en BelongsToMany, filesystem en view voor de migration-generator, http voor Request in de middleware, en support voor de facades, ServiceProvider en Str. Die pakketten stonden op ^13.0, wat betekende dat 2.5.8 Laravel 13 afdwong. Nu ^12.0|^13.0, zodat een tag kan landen zonder dat afnemers gelijktijdig mee moeten upgraden. Tot slot had makeFilterName() in de tests een impliciet nullable parameter, goed voor de laatste overgebleven deprecation. Getest op beide: 46 tests, 95 assertions, geen deprecations, phplint schoon op illuminate/support v12.65.0 en v13.24.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Het branches-filter op pull_request wordt door GitHub gewogen tegen de kopie van de workflow op de base branch, en daar staat nog master. De matrix draaide daardoor niet op deze PR. Filter eraf; push blijft beperkt tot main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chore: maak het pakket aantoonbaar Laravel 13 proof
Kale phplint scant ook vendor en struikelt dan over de fixture met een opzettelijke syntaxfout in overtrue/phplint zelf. Nu expliciet src, tests en rector.php, wat op dezelfde 24 bestanden uitkomt als de GitHub Action rapporteerde. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
De CI op main staat rood sinds dependabot overtrue/phplint van 9.5 naar 9.8 bumpte in #60. De action print zelf "[OK] 24 files" en eindigt daarna alsnog met een non-zero exit, zonder annotatie. De versie die draait meldt zich als 9.8.x-dev, want @9.8 is een meebewegende branch en geen vaste release. Dat betekent dat de lint op elk moment kan omvallen zonder dat er iets in deze repo verandert. Draai phplint daarom via het lint-script, op de versie die het pakket zelf in require-dev pint en op de PHP-versie die de rest van de CI ook gebruikt. Scheelt een third-party action in de keten en geeft dezelfde 24 bestanden. De job heet nu lint in plaats van build, wat beter beschrijft wat hij doet en niet botst met de matrix-jobs in de andere workflow. Branch protection op main heeft geen verplichte checks, dus de hernoeming blokkeert niets. De trigger stond op kale push, wat betekende dat hij ook draaide op branches zonder PR. Nu main plus pull requests, gelijk aan de andere workflow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ci: lint via het composer-script in plaats van de phplint action
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.